Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow Leopards | Anika SW #113

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Snow Leopards | Anika SW #113

wants to merge 23 commits into from

Conversation

anika-sw
Copy link

@anika-sw anika-sw commented Nov 28, 2022

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I ran the validator in VS Code as I was building the pages. The most common issue I ran into was not having a heading for a section.
Why is it important to consider and use semantic HTML? Semantic HTML makes the code easier to read. Explicit tags reduce guesswork.
How did you decide to structure your CSS? I started by thinking global and then local, but I'm realizing that toward the end of the project I stopped paying attention to this. I tried to put styles would apply more broadly toward the top of the style sheet so they'd cascade down. The rule-sets towards the bottom are more specific.
What was the most challenging piece of this assignment? Definitely the styling. I made a pixel art image with a grid container and it took me a minute to figure out that I needed a div for each pixel. Also, when things wouldn't appear as I thought they should, I had to dig through the various CSS rule sets to figure out why.
Describe one area that you gained more clarity on when completing this assignment This project increased by awareness of how individual elements interact with one another on a page. I played around with the layout a bit and observed how different padding or margins bumped up against one another. I look forward to learning more about responsive behaviors of various elements in the future.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? https://anika-sw.github.io/

…folio file, and builds out portfolio file per README.md instructions.
Copy link

@yangashley yangashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Your HTML is semantic, your organization makes sense to me, and I'm glad you got some practice with flexbox and css grid

<p>
Thank you for visiting my online portfolio!
</p>
<div id="grid-container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Good practice working on styling a grid and then applying different styles to each little box!

That seems like a tedious job.

In practice, you'd probably grab an image of the logo and use the image tag for it since that's more semantic, but I think you did this for practice with css grid.


<header>
<h1>Anika's Personal Portfolio: Projects</h1>
<nav>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nav is a child to the header tag, but the indentation is one level off. Think it needs to be indented one more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants