-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snow Leopards | Anika SW #113
base: master
Are you sure you want to change the base?
Conversation
…folio file, and builds out portfolio file per README.md instructions.
…ements to comply with W3C validation
…iles to obtain desired for pages in browser
…es.css for flex box formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Your HTML is semantic, your organization makes sense to me, and I'm glad you got some practice with flexbox and css grid
<p> | ||
Thank you for visiting my online portfolio! | ||
</p> | ||
<div id="grid-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Good practice working on styling a grid and then applying different styles to each little box!
That seems like a tedious job.
In practice, you'd probably grab an image of the logo and use the image tag for it since that's more semantic, but I think you did this for practice with css grid.
|
||
<header> | ||
<h1>Anika's Personal Portfolio: Projects</h1> | ||
<nav> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like nav is a child to the header tag, but the indentation is one level off. Think it needs to be indented one more time
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions