Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Bianca - Calculator #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

biciclista22
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. I stored the operation input into a variable and I stored the number values in an array, after confirming that they were, in fact, integer values.
How did you determine what operation to perform? I created a conditional statement that used methods I created at the beginning of my code. each if or elsif statement asked for a possible range of input - either the written word or the symbol used.
How did you make sure your program behaved correctly? I looked at the different test features/parameters and ran through examples of the mentioned requirements to make sure it would not break. When it broke, I would look at the error message and try to see what it was trying to tell me.
Do you feel like you used consistent indentation throughout your code? I believe I did. I used the control "I" shortcut in Atom to make sure. It became important when I started nesting conditionals within conditionals. Some funky indentation may remain because I altered the indentation spacing from 2 to 4 to make it more pronounced.
If you had more time, what would you have added to or changed about the program? I feel I am thinking too simply when creating my code. It felt somewhat repetitive and if I had more time and a better grasp of nuanced ways of storing code that dive a bit deeper than the simple problems and examples I have worked with, it could be more concise and DRY. I would play with the methods more, perhaps creating more complex methods just to stretch my mind a bit.

@PilgrimMemoirs
Copy link

PilgrimMemoirs commented Aug 14, 2017

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Well Done
Extras
Submission meets project expectations and learning goals. Nice Work!
Currently, this calculator only handles integers, which is not ideal for a calculator. How could you refactor to ensure you're getting a number, but allow the flexibility of having a float?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants