Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stef Gunderson -- Calculator -- Carets #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SesameSeeds
Copy link

@SesameSeeds SesameSeeds commented Aug 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. I used variables defined by methods in conditionals. I actually initially thought about doing it with arrays but then confused myself and decided simple was better.
How did you determine what operation to perform? I let the user make the choice of operation. They are using the calculator after all. If you're asking me why I made the choices I did, I determined to use what I was told to use and whatever would make it work. There wasn't a whole lot of crazy thought to it sadly.
How did you make sure your program behaved correctly? A metric eff-ton of testing and a lot of trail and error as I went.
Do you feel like you used consistent indentation throughout your code? I hope so, I had an issue with atom with my last program, things seem better this time . Super sorry about my menu. It looks fine on atom but as I create a pull request it seems to have changed a bit.
If you had more time, what would you have added to or changed about the program? After some much needed sleep I would have managed to get a while or until loop to work. I actually was unable to get mine to work (sick and overwhelmed), once that worked I'd get to all of the additional add-ons, since mine is just the base requirements to the best of my ability at this moment. I am trying to make sure I am fully comprehending things (since I overthink myself stupid) and retaining what I need to build on. Thus, I am sticking with basics and if I feel comfortable/competent I build out from there. I’m just not there yet. Otherwise if given the opportunity I would like to deal with better ways to deal with erroneous input for starters and branch from there by looking at string input, so on and so forth.

@CheezItMan
Copy link

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. Check
Baseline
Readable code with consistent indentation. Check
Extras
Summary Just FYI, you can have 0 in the numerator when doing division, just not denominator. Good use of if and elsif to determine the operation to perform. You hit all the requirements!

@SesameSeeds SesameSeeds changed the title Stef Gunderson -- Carets Stef Gunderson -- Calculator -- Carets Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants