Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pipes - Kate Evans-Spitzer - Calculator.rb #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Guribot
Copy link

@Guribot Guribot commented Aug 11, 2017

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program. User input was assigned to 3 separate variables - one for each number and one for the operator.
How did you determine what operation to perform? I made a hash that contained several arrays of possible terms for each operation (e.g. :add => ["+", "add", "plus"]), and the method would perform an operation depending on which key's value held the operator.
How did you make sure your program behaved correctly? Running it every time I made a change, trying small snippets of code in irb, and using "puts" to display variables as they were updated (in loops, if statements, etc) so that I could see how they were behaving.
Do you feel like you used consistent indentation throughout your code? Yes 👍
If you had more time, what would you have added to or changed about the program? Support for parentheses, multiple step equations, and the ability for the user to enter the entire equation as a single string rather than as 3 separate inputs.

@PilgrimMemoirs
Copy link

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. Well Done
Baseline
Readable code with consistent indentation. Well done
Extras
Great job splitting functionality into methods and maintaining DRY code.
Submission meets project expectations and learning goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants