Pipes - Rebecca - MediaRanker

[rbergena]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a custom method in the work model to get the top ten media in a category.
Describe how you approached testing that model method. What edge cases did you come up with?	I tested the case where the category has less than 10 items.
Describe an edge case test you wrote for a controller	In the works controller I tested a case for the upvote action where a loged in user tries to vote on the same work twice.
What are session and flash? What is the difference between them?	Flash displays a single time while session persists
Describe a controller filter you wrote.	I used a controller filter for finding a work by params id.
What was one thing that you gained more clarity on through this assignment?	Using dependent destroy and testing dependent destroy.
What is the Heroku URL of your deployed application	https://reber-mediaranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

[droberts-sea]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	yes
Errors are reported to the user	yes
Business logic lives in the models	yes
Models are thoroughly tested, including relations, validations and any custom logic	yes
Controllers are thoroughly tested	yes - good work testing upvote
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	yes
Splash page contains a media spotlight	yes
Media pages contain lists of voting users	yes
Wave 3 - Styling
Foundation is used appropriately	yes
Look and feel is similar to the original	yes - great work
Overall	Great work overall!

[droberts-sea]

Good use of a private helper method here.

[droberts-sea]

Good use of filters to DRY up this controller

[droberts-sea]

Pro tip: you can use erb inside a fixtures file. This could be shortened to something like

<% 20.times do |i| %>
user_<%= i %>:
  username: username_<%= i %>
  date_joined: 2017-10-<%= i %>
<% end %>

[droberts-sea]

I love these three test cases! Good work!