Shaunna Wiens --carets

[skwiens]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	A method to return a collection of works ordered from highest number of votes to lowest number of votes
Describe how you approached testing that model method. What edge cases did you come up with?	I wrote a test that used fixtures. It ensured that the correct order was returned and if there were no votes that the full length array was still returned.
Describe an edge case test you wrote for a controller	An edge case test that I wrote for a controller was not allowing a vote to be created unless a user is signed in.
What are session and flash? What is the difference between them?	'session' and 'flash' are hashes that are stored that you can access. The difference is that session is available until the browser is closed and flash is only available for the current and next request.
Describe a controller filter you wrote.	I wrote a controller filter for user so that the user that is signed in (in sessions) is available in all controllers and pre-defined as @user_in_session
What was one thing that you gained more clarity on through this assignment?	The connection between controllers and running multiple controllers as well as running a controller without any views
What is the Heroku URL of your deployed application	https://limitless-cliffs-55932.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Change the task of displaying the top works to a later stage. Also, I think it would be helpful to have questions in the pull request asking what we would do if we had more time, or what errors do we know that we still have. Also, I may have done this incorrectly, but I don't have many business logic models in my program. I think it would be helpful to have just a few more obvious business logic requirements int the assignment to practice working with them and testing with them.

[tildeee]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x
Comprehension questions	x
General
Rails fundamentals (RESTful routing, use of named paths)	x
Semantic HTML	x
Errors are reported to the user	x
Business logic lives in the models	x
Models are thoroughly tested, including relations, validations and any custom logic	x
Controllers are thoroughly tested	x
Wave 1 - Media
Splash page shows the three media categories	x
Basic CRUD operations on media are present and functional	x
Wave 2 - Users and Votes
Users can log in and log out	x
The ID of the current user is stored in the session	x
Individual user pages and the user list are present	x
A user cannot vote for the same media more than once	x
All media lists are ordered by vote count	x
Splash page contains a media spotlight	x
Media pages contain lists of voting users	x
Wave 3 - Styling
Foundation is used appropriately	x
Look and feel is similar to the original	✨
Overall

[tildeee]

Great job with this project-- the functionality is all there (including spotlight/sorting, which was pretty tricky) and a lot of the edge cases (like blank username)

The tests are all there and cover things pretty well so I'm pretty happy with this

Also, the site looks SPOT ON! Good job with the structure and styling of this entire app! It's perfect! :)

[tildeee]

Really good job with the work you did in:

• ApplicationController
• Work#order_by_popularity