Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tamira-Mariana-Pipes-VideoStoreConsumer #12

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

lmarianarp19
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Mariana: I learned how to implemented the bus. Tamira: Mariana had really good instinct on how to access data.
What was one area of Backbone you gained more clarity on during this assignment? We both feel more confident with views after this project.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We checked the name and release date, which both types of movies had, when comparing the two.
Describe how you handled rentals with Backbone? We did not do the optionals.
Describe a DOM event your application handled When you click the 'add movie' button it changes to 'Added movie' after the movie is added to the movieList collection.
Describe a custom event your application handled We used the bus to render status messages in other views. We triggered the bus in SearchView and listened to the event in SearchListView.
Do you have any recommendations on how we could improve this project for the next cohort?

tvojnar and others added 30 commits December 18, 2017 13:59
…a list of moveis that match the search query. this is in the searchForMovie function
can make a search query to the external api via the local api to get …
… but instead we are going to change our approach to check if we have the movie locally in our MovieList collection
@droberts-sea
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution yes
Comprehension questions yes
General
Search functionality yes
Rental library listing functionality yes
Add to rental library functionality yes
Underscore Templates yes
Overall Look & feel Simple but effective. You have a "see details" button for each movie but it doesn't seem to do anything.
Optionals
Overall Good work overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants