Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amy & Jan | Carets #13

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Amy & Jan | Carets #13

wants to merge 20 commits into from

Conversation

JNEdrozo
Copy link

@JNEdrozo JNEdrozo commented Dec 21, 2017

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project JE: From Amy, I was able to learn and observe how she problem solves using console logs to trace errors and helped me piece through view logic (to determine the scope and responsibility of specific movie views). AL: Jan is able to see and check in on the bigger picture and figure out how things connect and flow, between our VideoStoreConsumer App and our API.
What was one area of Backbone you gained more clarity on during this assignment? We gained more clarity on how to take advantage of setting up multiple views, so that each view is responsible for listening and handling specific events that happen in its respective scope.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content So in our app, we have 2 movie lists: one for movies that already exist in the rental library (without search) and one for the movie results, which is generated after completing a search. We only view one list at any point in time, but we change the header of the list container depending on when we are viewing the rental library list (pulled directly from the VideoStoreAPI) or the search results (from TMDB).
Describe how you handled rentals with Backbone? We didn't.
Describe a DOM event your application handled Any time we 'submit' on the search form, we trigger an event to show our results list, which entails hiding the container for the view we are currently in, and showing the container to view our ResultsList.
Describe a custom event your application handled In our movie details view, we have a custom event called "addMovie" which retrieves the movie view's model information and saves it as a new instance of a movie for the API. (NOTE: In order to save this new instance of a movie in the VideoStoreAPI, we modified the routes and movie_controller file to add a create method).
Do you have any recommendations on how we could improve this project for the next cohort? Timing for this project is rough. There are many great lessons to be extracted from this project, but it takes a little bit more time to research topics on our own for a Level 3 pair project. It would have been a great project to work on for a full week.

JNEdrozo and others added 20 commits December 18, 2017 13:35
…rental library (and commented out movie_list.js parse method)
@tildeee
Copy link

tildeee commented Jan 3, 2018

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution x
Comprehension questions x
General
Search functionality x
Rental library listing functionality x
Add to rental library functionality There's a bug! :) Hehehehe. I'm documenting it below
Underscore Templates x
Overall Look & feel x
Optionals
Overall

When you are browsing, if you view a series of movies and return to the search results, and then eventually, rent a movie, it'll add the two most recently viewed movies. To reproduce:

  1. Search for the term "matrix"
  2. Click on "The Matrix: ASCII"
  3. Click on "Back to Results"
  4. Click on "The Matrix"
  5. Click on "Add Movie to Library"
  6. Observe that both "The Matrix" and "The Matrix: ASCII" are added to the rental library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants