Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Irene & Lindsey - VideoStore #20

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Conversation

idevera
Copy link

@idevera idevera commented Dec 21, 2017

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Learned how to use radio buttons to show different views. Setting up views for all the models
What was one area of Backbone you gained more clarity on during this assignment? How to setup views with backbone models
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We handled the movies by creating a Movie model and a template that would display upon the call of the rails API. We also had an associated view that would display a view of each movie
Describe how you handled rentals with Backbone? We used Returned Movie Models and Movie Models to handle the movies that are mostly the same but have slight differences
Describe a DOM event your application handled The radio buttons that we added allowed us to show and hide specific backbone views from the user based on what the user wanted
Describe a custom event your application handled One custom event that we created was using a bus trigger to send a ReturnedMovie Model over to the Movie List Collection so that it can be converted to a Movie in the rental store
Do you have any recommendations on how we could improve this project for the next cohort? Good for the right amount of time we have

@droberts-sea
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution yes
Comprehension questions yes
General
Search functionality yes
Rental library listing functionality yes
Add to rental library functionality yes
Underscore Templates yes
Overall Look & feel yes - Clean, simple, and very usable. Good work.
Optionals
Overall Great work overall! I appreciate your dedication to tests and model validation.

addToCollection(attributes) {
const newMovie = new Movie(attributes);
if (newMovie.isValid()) {
const movieView = new MovieView({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a MovieView here and appending its HTML directly to the DOM, it would probably make more sense to add the newMovie to the movie list. That would trigger an update event, which would be handled by render, resulting in the same thing.

Aside from being DRYer, the fact that you don't add the movie to the list here means that if this view re-renders for some other reason, the newly added movie will be absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants