Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gale Harrington - Carets #37

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Gale Harrington - Carets #37

wants to merge 20 commits into from

Conversation

galestorm
Copy link

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How do Backbone Views help structure your code? It provided some organization by breaking up code that would have all ended up in a really unwieldy app.js file without views. I found that working with Views made the structure of the program more similar to a Rails-y MVC structure
Did you use jQuery directly in your Views? How, and why? No: I used the this.$ which I think is not the same as using jQuery directly...
What was an example of an event you triggered? Why did you need to trigger it? I triggered a custom 'priceChage' event whenever a quote model's price changed. I did this because Order needed to know a quote's current price for validations and to know when to execute
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different? Overall, it is familiar spec-style testing where we do a sanity check, run some code, and then define an expectation for after the code has run. Jasmine's spy concept was sort of strange to me , though: I'm not exactly sure what an analogy would be in Ruby unit tests or whether I used spies correctly in my unit tests for this project.

@tildeee
Copy link

tildeee commented Jan 2, 2018

Ada Trader

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Organization
Models and collections are defined in separate files x
Code that relies on the DOM is located in or called by $(document).ready x
Functionality
Quote prices change when clicking Buy and Sell x
The Trade History updates when buying and selling a quote x
A user can create an open order using the Order Entry Form x
An open order removes itself from the open orders and updates the Trade History when fulfilled x
General
Has separate views for different parts of the app x
Uses events (listening/handling and triggering) to manage different behavior in views
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render) x
Error handling for the Order Entry Form x
Testing
Has unit tests for models x
Overall

@tildeee
Copy link

tildeee commented Jan 2, 2018

Overall, good work! Event-driven programming is always interesting, especially in contrast with the message-driven programming we've done otherwise. Keep in mind that event-driven is not the only solution available. Otherwise, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants