Provide control over -fcallgraph-info in project wizard. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [GCC PR 104342](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104342) we can see that, if checking out a non-release compiler (e.g. GCC 14.0.1), having `-gnata` and `-fcallgraph-info=su` will cause a crash (in stm32 code, anyway). `-gnata` is used when Build is Debug. This patch amends the Project Wizard so you can specify `CALLGRAPHS=Disabled`. * scripts/project_wizard.py (Build_Checks_Type): renamed to Disabled_Or_Enabled_Type. (Build_Checks): now Disabled_Or_Enabled_Type. (Callgraphs): new, checks external CALLGRAPHS, default Enabled. Used to decide whether to include -fcallgraph-info=su even if Target isn't riscv32-unknown-elf.
pat-rogers
approved these changes
Feb 27, 2024
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GCC PR 104342 we can see that, if checking out a non-release compiler (e.g. GCC 14.0.1), having
-gnataand-fcallgraph-info=suwill cause a crash (in stm32 code, anyway).-gnatais used when Build is Debug.This patch amends the Project Wizard so you can specify
CALLGRAPHS=Disabled.