Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translation zh.json #582

Merged
merged 16 commits into from
Jan 12, 2024
Merged

feat: translation zh.json #582

merged 16 commits into from
Jan 12, 2024

Conversation

juliahermak
Copy link
Member

@juliahermak juliahermak commented Jan 10, 2024 •
edited
Loading

Screenshot 2024-01-10 23 50 10
Screenshot 2024-01-10 23 49 46

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 5:50pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Deployed to https://msg-adamant-pr-582.surge.sh 🚀

@juliahermak juliahermak changed the title feat: translation zh.json and configure it in vue-i18n feat: translation zh.json Jan 10, 2024
@juliahermak
Copy link
Member Author

Translate the app to Chinese language

adamant-al
adamant-al requested changes Jan 11, 2024
View reviewed changes
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
adamant-al
adamant-al reviewed Jan 11, 2024
View reviewed changes
src/locales/zh.json Outdated Show resolved Hide resolved
@adamant-al
Copy link
Member

@juliahermak
Please check for mistakes like ｛crypto} once more.

@juliahermak
Copy link
Member Author

@adamant-al I corrected all the wrong characters that I found.

@adamant-al
Copy link
Member

@juliahermak
I think you are doing wrong with commas and { }.
In Chinese, punctuation symbols go with spaces as a single character.
So you better revert this commit.

@bludnic bludnic mentioned this pull request Jan 12, 2024
Merged
@bludnic
Copy link
Member

bludnic commented Jan 12, 2024

Chinese {} chars don't work when used as a variables like {crypto}, {amount}. So the chars were replaced by a regular {} (without spaces).

@adamant-al probably better to ask Chen. Can he make a suggestions in this PR?

@adamant-al
Copy link
Member

Chinese {} chars don't work when used as a variables like {crypto}, {amount}. So the chars were replaced by a regular {} (without spaces).

@adamant-al probably better to ask Chen. Can he make a suggestions in this PR?

Not necessary to ask him.
Use regular { } and spaces around.

@bludnic bludnic merged commit 963112e into dev Jan 12, 2024
3 checks passed
@bludnic bludnic deleted the Feat/translate-the-app-to-Chinese-language branch January 12, 2024 17:50
@github-actions GitHub Actions
Copy link

Successfully tore down https://msg-adamant-pr-582.surge.sh 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamant-al adamant-al adamant-al approved these changes

@bludnic bludnic bludnic approved these changes

@RealGoodProgrammer RealGoodProgrammer Awaiting requested review from RealGoodProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliahermak @adamant-al @bludnic