Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsupported transaction #631

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Handle unsupported transaction #631

merged 5 commits into from
Jun 4, 2024

Conversation

bludnic
Copy link
Member

@bludnic bludnic commented Jun 4, 2024

Handle unsupported transaction types (e.g. for AIP-18: Decentralized file transfer) in old versions of the messenger.

image

We can introduce other types of transactions in the future, so it will break the app every time until we make a new release and update the client.

Added a fix in normalizeMessage.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 5:55pm

@bludnic
Copy link
Member Author

bludnic commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

Deployed to https://msg-adamant-pr-631.surge.sh 🚀

src/locales/ru.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
@bludnic bludnic merged commit c97eb2f into dev Jun 4, 2024
3 checks passed
@bludnic bludnic deleted the fix/unsupported-transaction branch June 4, 2024 17:58
Copy link

github-actions bot commented Jun 4, 2024

Successfully tore down https://msg-adamant-pr-631.surge.sh 🥲

@adamant-al
Copy link
Member

It's better to show this message as italic and in {} or [].

@bludnic
Copy link
Member Author

bludnic commented Jun 4, 2024

It's better to show this message as italic and in {} or [].

Noted: https://trello.com/c/yxpIYa9Y/546-style-unsupported-transaction-type

@adamant-al
Copy link
Member

@bludnic
Check how we already show ~"Unable to decrypt transaction".

@bludnic bludnic mentioned this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants