Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot switch between front and back camera #633

Merged
merged 14 commits into from
Jul 3, 2024
Merged

fix: Cannot switch between front and back camera #633

merged 14 commits into from
Jul 3, 2024

Conversation

aineo
Copy link
Contributor

@aineo aineo commented Jun 10, 2024 •
edited
Loading

  • chore: update @zxing/library to version 21
  • chore: update @zxing/browser to version 5
  • fix: mobile devices can contain more than two cameras
  • chore: refactor QrCodeScannerDialog component to composition api
  • chore: change base Scanner library from@zxing/library to @zxing/browser
  • fix: cannot switch between front and back camera
  • chore: code review, typings, code simplifying
  • fix: no auto request of camera permissions for chrome
  • fix, chore: stop scanner controls and video tracks after closing modal window
  • fix, chore: back camera on android by facing mode, use lib only for QR decoding

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 3:45pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Deployed to https://msg-adamant-pr-633.surge.sh 🚀

@aineo
Copy link
Contributor Author

aineo commented Jun 10, 2024

Cannot switch between front and back camera

@aineo
Copy link
Contributor Author

aineo commented Jun 14, 2024

Refactor QrcodeScannerDialog.vue to Composition API

@aineo aineo changed the title [wip] fix: Cannot switch between front and back camera fix: Cannot switch between front and back camera Jun 14, 2024
bludnic
bludnic requested changes Jun 14, 2024
View reviewed changes
src/lib/zxing/index.ts Outdated Show resolved Hide resolved
src/components/QrcodeScannerDialog.vue Outdated Show resolved Hide resolved
src/lib/zxing/index.ts Outdated Show resolved Hide resolved
src/components/QrcodeScannerDialog.vue Outdated Show resolved Hide resolved
src/components/QrcodeScannerDialog.vue Outdated Show resolved Hide resolved
@Adamant-im Adamant-im deleted a comment from aineo Jun 17, 2024
@aineo aineo force-pushed the fix/switch-between-front-back-camera-qr branch from 726ec12 to 074e116 Compare July 1, 2024 15:48
bludnic
bludnic requested changes Jul 2, 2024
View reviewed changes
src/lib/zxing/index.ts Outdated Show resolved Hide resolved
src/lib/zxing/index.ts Outdated Show resolved Hide resolved
@aineo aineo force-pushed the fix/switch-between-front-back-camera-qr branch from d492b23 to 808abe0 Compare July 2, 2024 15:36
@aineo aineo force-pushed the fix/switch-between-front-back-camera-qr branch from 808abe0 to e2857e2 Compare July 2, 2024 15:44
@bludnic bludnic requested a review from PaulDremanovich July 3, 2024 06:31
@RealGoodProgrammer
Copy link
Member

2024-07-03 13 14 00
You need to check permissions and request them if they have not been granted

@RealGoodProgrammer
Copy link
Member

Sometimes an app tries to get permission, but for some reason it can't, and we get into an endless loop. I use the Brave browser

telegram-cloud-document-2-5199598248758628756.mp4

RealGoodProgrammer
RealGoodProgrammer requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@RealGoodProgrammer RealGoodProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a permissions issue with some browsers.

@aineo
Copy link
Contributor Author

aineo commented Jul 3, 2024

What browsers do this problem occur with other than Brave (I couldn’t reproduce it myself, Brave version 1.66.2 (124))?

@RealGoodProgrammer
Copy link
Member

What browsers do this problem occur with other than Brave (I couldn’t reproduce it myself, Brave version 1.66.2 (124))?

Chrome works fine. I think it would be better to create a separate task for this problem.

@bludnic
Copy link
Member

bludnic commented Jul 3, 2024

Sometimes an app tries to get permission, but for some reason it can't, and we get into an endless loop. I use the Brave browser

telegram-cloud-document-2-5199598248758628756.mp4

Task: https://trello.com/c/Kb7V9YGH/572-endless-camera-permission-request-in-brave-browser

@bludnic
Copy link
Member

bludnic commented Jul 3, 2024

Merge it @RealGoodProgrammer

@RealGoodProgrammer RealGoodProgrammer merged commit 366b0f5 into dev Jul 3, 2024
3 checks passed
@RealGoodProgrammer RealGoodProgrammer deleted the fix/switch-between-front-back-camera-qr branch July 3, 2024 15:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Successfully tore down https://msg-adamant-pr-633.surge.sh 🥲

@bludnic bludnic mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDremanovich PaulDremanovich PaulDremanovich approved these changes

@RealGoodProgrammer RealGoodProgrammer RealGoodProgrammer approved these changes

@bludnic bludnic bludnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aineo @RealGoodProgrammer @bludnic @PaulDremanovich