Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withoutDirectTrasnfers param for the chats/get endpoint #91

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

yoxira
Copy link
Member

@yoxira yoxira commented Dec 17, 2024

@yoxira
Copy link
Member Author

yoxira commented Dec 17, 2024

To do: tests

@yoxira yoxira marked this pull request as ready for review December 17, 2024 02:10
@yoxira yoxira requested a review from bludnic December 17, 2024 02:10
@yoxira
Copy link
Member Author

yoxira commented Dec 17, 2024

@adamant-al
Setting ?withoutDirectTransfers to false by default is very confusing due to double negative, can we rename the property name? e.g., to includeDirectTransfers

@yoxira yoxira requested a review from adamant-al December 17, 2024 02:46
@yoxira yoxira added the feature label Dec 18, 2024
@yoxira yoxira self-assigned this Dec 18, 2024
@adamant-al
Copy link
Member

@adamant-al Setting ?withoutDirectTransfers to false by default is very confusing due to double negative, can we rename the property name? e.g., to includeDirectTransfers

Yes, but let's add includeDirectTransfers where it's currently withoutDirectTransfers

It’s supported by the api/chatrooms endpoint (here default withoutDirectTransfers=0.

And deprecate withoutDirectTransfers.
If both options included, withoutDirectTransfers is a priority.

@yoxira yoxira marked this pull request as draft December 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants