feat: add timestampMs for transactions
#93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamant-al
reviewed
Dec 18, 2024
| @@ -476,6 +479,10 @@ Transaction.prototype.verify = function (trs, sender, requester, cb) { | |||
| return setImmediate(cb, 'Missing sender'); | |||
| } | |||
|
|
|||
| if (typeof trs.timestampMs !== 'number') { | |||
There was a problem hiding this comment.
Will previous txs/blocks be valid?
It's important to keep backward compatibility.
| @@ -647,10 +654,26 @@ Transaction.prototype.verify = function (trs, sender, requester, cb) { | |||
| if (trs.timestamp < INT_32_MIN || trs.timestamp > INT_32_MAX) { | |||
| return setImmediate(cb, 'Invalid transaction timestamp. Timestamp is not in the int32 range'); | |||
| } | |||
| if (slots.getSlotNumber(trs.timestamp) > slots.getSlotNumber()) { | |||
|
|
|||
| if (Math.abs(trs.timestampMs - trs.timestamp * 1000) >= 1000) { | |||
There was a problem hiding this comment.
Will previous txs/blocks be valid?
| return setImmediate(cb, 'Invalid transaction timestamp. Timestamp and timestampMs delta is greater than 1000ms'); | ||
| } | ||
|
|
||
| const currentTime = slots.getTime(); |
There was a problem hiding this comment.
Returns time in seconds, not in ms, right?
|
Ensure that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/IN62zyEb/114-feat-verify-store-and-return-unixtimestamp-for-txs