Impelment UISK Tokens into FX/Dark Mode #2333
Conversation
SHolleworth
changed the title
SHolleworth
changed the title
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
| const [hovering, setHovering] = useState(false) | ||
| const color = basePnl >= 0 ? "positive" : "negative" | ||
| const color = profitOrLossValue >= 0 ? "positive" : "negative" |
There was a problem hiding this comment.
can we map colors in the theme, so we reference the pos/neg colors by name - I am doing this in RTEq MUI theme, as we did in UISK v1
There was a problem hiding this comment.
will clear your E2E failure too
There was a problem hiding this comment.
removed in the tweaks pr, the pnl bars dont change colour anymore
| basePnl: -849.4217864553628, | ||
| maxVal: 1785.9428620191757, | ||
| profitOrLossValue: -849.4217864553628, | ||
| largetProfitOrLossValue: 1785.9428620191757, |
There was a problem hiding this comment.
typo - restore the type info, perhaps - it needs to be corrected there, too
There was a problem hiding this comment.
fixed in the tweaks pr
| const AnalyticsRegion = styled(Region)` | ||
| width: 320px; | ||
| background-color: ${({ theme }) => | ||
| theme.newTheme.color["Colors/Background/bg-primary"]}; |
There was a problem hiding this comment.
thinking about this .. looks awkward .. no immediate actions, but I'd like to do better around color refs .. in RTEq I am doing all the fiddly mapping in theme.ts
| @@ -43,13 +42,13 @@ export const Analytics = ({ hideIfMatches = "(max-width: 750px)" }: Props) => { | |||
|
|
|||
| return ( | |||
| <AnalyticsWrapper ref={ref} hideIfMatches={hideIfMatches}> | |||
| <Suspense fallback={loader}> | |||
| <RegionWrapper fallback={loader}> | |||
There was a problem hiding this comment.
I've refactored all the major lazy load wrappers (live rates, rfqs, etc) to use this RegionWrapper, as they were all doing basically the same thing.
| {supportsTearOut && <TearOutComponent section="analytics" />} | ||
| </RightNav> | ||
| </AnalyticsHeader> | ||
| <AnalyticsRegion |
There was a problem hiding this comment.
I've refactored all the sections of the app to use this Region component, since their layouts and stuctures all share a lot of commanalities.
| source$={analytics$} | ||
| fallback={children} | ||
| Header={ | ||
| <TabBar |
There was a problem hiding this comment.
The headers for all the regions are now using the tabbar component, which also renders all the icon buttons (tear out, tile chart view, etc) called actions here
|
|
||
| import { SectionLayout } from "@/client/components/layout/SectionLayout" |
There was a problem hiding this comment.
Maybe I should rename this to AnalyticsSectionLayout?
No description provided.