Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ember 2.4 from the test matrix #868

Merged
merged 2 commits into from
Feb 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
matrix:
ember-version:
[
ember-lts-2.4,
ember-lts-2.8,
ember-lts-2.12,
ember-lts-2.18,
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ handle over 100,000 rows without any rendering or performance issues.

Ember Table 3.x supports:

* Ember 2.4 to latest version of Ember.
* Ember 2.8 to latest version of Ember.

For older platforms, the final release of Ember Table 2.x (2.2.3) supports:

Expand Down
31 changes: 0 additions & 31 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,37 +9,6 @@ module.exports = function() {
return {
useYarn: true,
scenarios: [
{
name: 'ember-lts-2.4',
bower: {
dependencies: {
ember: 'components/ember#lts-2-4',
},
resolutions: {
ember: 'lts-2-4',
},
},
npm: {
resolutions: {
// ember-math-helpers has a dependency on newer htmlbars and it
// conflicts this older version of ember with a message:
// "ember-cli-htmlbars: Cannot find the ember-source addon"...
'ember-cli-htmlbars': '^3',
// The 1.2.2 release causes an error related to a missing 'match'
// property which is due to the lack of ember-source.
// See https://github.com/pzuraq/ember-compatibility-helpers/issues/47
'ember-compatibility-helpers': '1.2.1',
},
dependencies: {
'ember-compatibility-helpers': '1.2.1',
},
devDependencies: {
'ember-source': null,
'ember-cli-addon-docs': null,
'ember-angle-bracket-invocation-polyfill': null,
},
},
},
{
name: 'ember-lts-2.8',
bower: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Legacy Usage

Ember Table is compatible (and tested) with Ember 2.4 and up.
Ember Table is compatible (and tested) with Ember 2.8 and up.

## Usage with Ember 2.4-2.11
## Usage with Ember 2.8-2.11

You may have noticed that all of the examples for Ember Table on this docs site
are using angle bracket syntax (.e.g. `foo-bar`). This is an exciting new
Expand Down