Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open overflowMenu action #332

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Add open overflowMenu action #332

merged 2 commits into from
Dec 2, 2019

Conversation

EsteveAguilera
Copy link
Contributor

Added function to open the overflow menu without clicking any item, as requested on #331

alorma
alorma reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@alorma alorma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there's more than one overflow menu on the screen?

@EsteveAguilera
Copy link
Contributor Author

Well, I don't really know 🤷‍♂

If you check the code changes, I've just used the openOverflow() function which calls the openActionBarOverflowOrOptionsMenu of espresso. No menu id is used anywhere.

@alorma alorma merged commit aba7161 into AdevintaSpain:master Dec 2, 2019
@alorma
Copy link
Member

alorma commented Dec 2, 2019

Thanks @EsteveAguilera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alorma alorma alorma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EsteveAguilera @alorma