docker: Remove CAP_NET_BIND_SERVICE capability #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capability was added in commit 58868b7, but since then, the USER instruction was removed from the Dockerfile, so that Adguard Home runs as root by default. Even if it is run as non-root user, the capability is not required in docker versions >= 20.10.0 (released on Dec 9, 2020), because of commit 888da28[1], which sets `net.ipv4.ip_unprivileged_port_start` to `0` by default. Users running older docker versions or using the `host` network mode can still configure this sysctl manually. [1] moby/moby@888da28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capability was added in commit 58868b7, but since then, the USER instruction was removed from the Dockerfile, so that Adguard Home runs as root by default.
Even if it is run as non-root user, the capability is not required in docker versions >= 20.10.0 (released on Dec 9, 2020), because of commit 888da28[1], which sets
net.ipv4.ip_unprivileged_port_startto0by default. Users running older docker versions or using thehostnetwork mode can still configure this sysctl manually.[1] moby/moby@888da28