Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp offer ip by client id in dhcpv4 #6110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nmreadelf
Copy link

@nmreadelf nmreadelf commented Aug 17, 2023

I have configured a virtual machine that utilizes the host network on my physical machine. Upon examination, I discovered that the AdGuard Home server being hosted offers IP addresses based on the MAC address of the physical host machine rather than the virtual machine itself. Specifically, the actual MAC address of the virtual machine is present in the client-id field of DHCP requests. For proper functionality, the DHCP server should be offering IP addresses based on the client-id field, which contains the MAC address of the virtual machine. This would allow the DHCP server to correctly identify the virtual machine and provide it an IP address accordingly. The current behavior indicates a misconfiguration, where the DHCP server is assigning IP addresses using the physical host's MAC address instead of the virtual machine client's MAC address contained in the DHCP request.

resolve #6135

@nmreadelf nmreadelf changed the title Judge client id in dhcpv4 dhcp offer ip by client id in dhcpv4 Aug 17, 2023
@nmreadelf nmreadelf marked this pull request as draft August 17, 2023 03:22
@nmreadelf nmreadelf marked this pull request as ready for review August 17, 2023 08:53
@nmreadelf nmreadelf marked this pull request as draft August 17, 2023 09:59
@nmreadelf nmreadelf marked this pull request as ready for review August 17, 2023 10:14
@ainar-g ainar-g requested a review from EugeneOne1 August 21, 2023 14:19
@ainar-g ainar-g added this to the v0.107.37 milestone Aug 21, 2023
@EugeneOne1
Copy link
Member

EugeneOne1 commented Aug 23, 2023

Hi @nmreadelf, sorry for the late reply and thanks for the contribution.

As far as I know, RFC-4361 Section 6.1, which updates the referenced RFC-2132, actually forbids using the hardware address in option 61 alone. However, a cursory internet search indicated that this feature may be somewhat useful, so could you please file a "feature request" issue so that we can see if it's actually the case?

Copy link
Member

@EugeneOne1 EugeneOne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

@nmreadelf
Copy link
Author

Hi @nmreadelf, sorry for the late reply and thanks for the contribution.

As far as I'm know, RFC-4361 Section 6.1, which updates the referenced RFC-2132, actually forbids using the hardware address in option 61 alone. However, a cursory internet search indicated that this feature may be somewhat useful, so could you please file a "feature request" issue so that we can see if it's actually the case?

relate #6135

@nmreadelf
Copy link
Author

nmreadelf commented Oct 7, 2023

@EugeneOne1 @ainar-g hello, i resolve merge conflicts, can you make approve again?

@nmreadelf
Copy link
Author

@EugeneOne1 @ainar-g hello, Could you please assist in merging this pull request? It has been open for close to a year.

Copy link
Member

@EugeneOne1 EugeneOne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmreadelf, good afternoon and apologies for late review. The reactions to the issue proposing this change seem to not have demonstrated the need for it. In addition, you never responded to our concerns about the standard's recommendations. So, we are not ready to merge this change.
You can always keep this feature in your personal fork of AdGuard Home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allocate IP address based on the MAC address in the client identifier.
3 participants