Add currency display in Wrath Classic #715
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #707
Refactored a bit of the currency frame module to allow it to work with the currency API in Wrath Classic. With the old version, the GetCurrency local variables that were just making copies of the globals in Retail were overwriting those functions of the same name in Wrath Classic. Therefore, they needed to be renamed.
Otherwise, everything else is pretty straightforward. I wrote some functions to handle the differences between the two in an attempt to minimize the changes to the pre-existing codebase (159-181). Please have a look at these and let me know if you have a better solution in mind.
Lastly, I needed to take the GetCurrencyListInfo() from Wrath Classic and convert the resultant data to fit the mold of its retail counterpart. After all of this, it works great on Wrath Classic!
Sadly, I do not have a retail character, so I cannot test this PR on there. There should be no adverse effects, but it'd be helpful if someone could test these changes out and provide feedback on their results.
Here's a picture! =)