Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 2.4.6 GraphQL schema #329

Merged
merged 3 commits into from
May 24, 2024
Merged

Restore 2.4.6 GraphQL schema #329

merged 3 commits into from
May 24, 2024

Conversation

jhadobe
Copy link
Contributor

@jhadobe jhadobe commented May 23, 2024 •
edited
Loading

This PR adds the older GraphQL schema for 2.4.6, following a request from the field.

I have removed the unused beta structure.

Staging

For a quick sanity check, i've confirmed the following are in the 2.4.7 version but NOT in the 2.4.6 version:

  • clearCart mutation
  • recaptchaV3Config queries

@jhadobe jhadobe added technical Changes to code, examples, or technical processes new-topic New original content labels May 23, 2024
@jhadobe jhadobe self-assigned this May 23, 2024
@jhadobe jhadobe marked this pull request as draft May 23, 2024 20:46
jeff-matthews
jeff-matthews reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments in the changed files, but I also think reusing the beta configs and static directories could cause problems if/when we start publishing the next beta schema in October.

src/data/navigation/sections/graphql.js Outdated Show resolved Hide resolved
src/pages/graphql/reference/legacy/index.md Outdated Show resolved Hide resolved
@jhadobe
Copy link
Contributor Author

jhadobe commented May 23, 2024

@jeff-matthews ready for re-review, the staging environment seems to have cached the old menu structure, may need to view in incognito.

@jhadobe jhadobe marked this pull request as ready for review May 23, 2024 22:11
jeff-matthews
jeff-matthews reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @jhadobe. Just a small request on the TOC.

src/data/navigation/sections/graphql.js Outdated Show resolved Hide resolved
jeff-matthews
jeff-matthews reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to comment on the index.md file for 2.4.6.

src/pages/graphql/reference/2.4.6/index.md Outdated Show resolved Hide resolved
@jeff-matthews jeff-matthews merged commit 8799364 into main May 24, 2024
15 checks passed
@jeff-matthews jeff-matthews deleted the jh_restore-schema branch May 24, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Assignees

@jhadobe jhadobe

Labels
new-topic New original content technical Changes to code, examples, or technical processes
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhadobe @jeff-matthews