Toolchain upgrade and Nostalgia mappings #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babric-loom-extensionis a Gradle plugin that plugs into the officialfabric-loomandfabric-loader. This plugin replaces the specializedbabric-loomandbabric-loaderwhich are poorly maintained as of today.Remap codebase to Nostalgia mappings which is more complete and maintained. Nostalgia mappings are TinyV2 which is also required for the new toolchain, while the previous Babric Yarn (Barn) mappings were TinyV1.
This PR does not properly rename all members to the new terms:
@Mixin(Block.class) MixinBlockis now@Mixin(Tile.class) MixinBlock(correct target, bad name).@Shadowmembers should be properly remapped (correctness not properly verified).@Override-ed vanilla methods.World worldremain asLevel world.This list is ordered in importance of fixing. N1 and N2 are next on the
crafting tablechopping block. N3 is difficult since I have no proper tools to verify and this PR already took too much manual and error-prone effort.N4 and N5 are not important but are nice to have, and could be done all at once or piece by piece.