Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument player optimizations #52

Merged
merged 12 commits into from
Oct 2, 2023
Merged

Instrument player optimizations #52

merged 12 commits into from
Oct 2, 2023

Commits on Sep 30, 2023

  1. Tofu on AC_ItemInstrument

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    aa50f9d View commit details
    Browse the repository at this point in the history

  2. Tofu on MusicPlayer

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    88293c3 View commit details
    Browse the repository at this point in the history

  3. Documentation on ExSignBlockEntity

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    d1d5c2c View commit details
    Browse the repository at this point in the history

  4. Document instrument is a uri

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    ecb2f40 View commit details
    Browse the repository at this point in the history

  5. Document instrument constructor

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    588c34a View commit details
    Browse the repository at this point in the history

  6. Generalized ExSignBlockEntity.java into ExSongContainer

    @Kiroto
    Kiroto committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    eac4049 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Phase out the old play note from song's implementation in favor of on… 

    …e that doesn't loop through the whole string for every note.
    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    2649f27 View commit details
    Browse the repository at this point in the history

  2. Tofu on naming conventions

    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    302e9a7 View commit details
    Browse the repository at this point in the history

  3. Removed unused sections of code

    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    fa75ccb View commit details
    Browse the repository at this point in the history

  4. Instruments can now be tuned and are used in sign playing

    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    a77c3bb View commit details
    Browse the repository at this point in the history

  5. Use instrument configs for playing sign sounds and instrument item so… 

    …unds.
    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    771f85f View commit details
    Browse the repository at this point in the history

  6. Do not want to modify the default keyboard notes array

    @Kiroto
    Kiroto committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    35c5dec View commit details
    Browse the repository at this point in the history