Applied changes from code review

Adyen · Dec 1, 2023 · 863360c · 863360c
1 parent 287d338
commit 863360c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/ios/Classes/components/ComponentPlatformApi.swift b/ios/Classes/components/ComponentPlatformApi.swift
@@ -1,4 +1,5 @@
 class ComponentPlatformApi: ComponentPlatformInterface {
+    //TODO: Group callbacks in a weak delegate
     var onUpdateViewHeightCallback: () -> Void = {  }
     var onActionCallback: ([String?: Any?]) -> Void = { _ in }
     var onFinishCallback: (PaymentFlowOutcomeDTO) -> Void = { _ in  }

diff --git a/ios/Classes/components/card/BaseCardComponent.swift b/ios/Classes/components/card/BaseCardComponent.swift
@@ -61,7 +61,6 @@ class BaseCardComponent: NSObject, FlutterPlatformView, UIScrollViewDelegate {
 
     func finalizeAndDismiss(success: Bool, completion: @escaping (() -> Void)) {
         cardComponent?.finalizeIfNeeded(with: success) { [weak self] in
-            //Is this viewcontroller access correct?
             self?.getViewController()?.dismiss(animated: true , completion:  {
                 completion()
             })

diff --git a/...sses/components/card/advancedFlow/delegates/CardAdvancedFlowActionComponentDelegate.swift b/...sses/components/card/advancedFlow/delegates/CardAdvancedFlowActionComponentDelegate.swift
@@ -19,8 +19,7 @@ class CardAdvancedFlowActionComponentDelegate: ActionComponentDelegate {
     }
 
     func didComplete(from _: Adyen.ActionComponent) {
-        print("did complete")
-        // TODO: Could we discuss when this callback is being triggered and needs to be handled?
+        //Only for voucher payment method
     }
 
     func didFail(with error: Error, from _: Adyen.ActionComponent) {

diff --git a/ios/Classes/components/card/session/delegates/CardSessionFlowDelegate.swift b/ios/Classes/components/card/session/delegates/CardSessionFlowDelegate.swift
@@ -25,7 +25,6 @@ class CardSessionFlowDelegate: AdyenSessionDelegate {
     }
 
     func didOpenExternalApplication(component _: ActionComponent, session _: AdyenSession) {
-        print("did open external application")
-        // TODO: Could we discuss when this callback is being triggered and needs to be handled?
+        // TODO: Add implementation when we support external applications
     }
 }