Support empty responses (#581)

Adyen · Nov 2, 2023 · 5940427 · 5940427
1 parent b043fa6
commit 5940427
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 35 deletions.
diff --git a/src/Adyen/Service.php b/src/Adyen/Service.php
@@ -87,7 +87,11 @@ function ($val) {
             $url .= '?' . http_build_query($queryParams);
         }
 
-        return $curlClient->requestHttp($this, $url, $bodyParams, $method, $requestOptions);
+        $response = $curlClient->requestHttp($this, $url, $bodyParams, $method, $requestOptions);
+        if (!is_array($response)) {
+            return [];
+        }
+        return $response;
     }
 
     /**

diff --git a/tests/Resources/ModelBasedCheckout/deleteStoredPaymentMethods-success.json b/tests/Resources/ModelBasedCheckout/deleteStoredPaymentMethods-success.json
diff --git a/tests/Unit/ModelBasedCheckoutTest.php b/tests/Unit/ModelBasedCheckoutTest.php
@@ -1,7 +1,8 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace Adyen\Tests\Unit;
 
+use Adyen\AdyenException;
 use Adyen\Model\Checkout\Amount;
 use Adyen\Model\Checkout\CardDetailsRequest;
 use Adyen\Model\Checkout\CheckoutPaymentMethod;
@@ -309,25 +310,17 @@ public static function successGetStoredPaymentMethodsProvider()
     }
 
     /**
-     * @param string $jsonFile
-     * @param int $httpStatus
-     *
-     * @dataProvider successDeleteStoredPaymentMethodsProvider
+     * @throws AdyenException
      */
-    public function testDeleteStoredPaymentMethodsSuccess($jsonFile, $httpStatus)
+    public function testDeleteStoredPaymentMethodsSuccess()
     {
-        $client = $this->createMockClient($jsonFile, $httpStatus);
+        $client = $this->createMockClient(null, 204);
 
         $service = new RecurringApi($client);
 
         $service->deleteTokenForStoredPaymentDetails("123");
-    }
 
-    public static function successDeleteStoredPaymentMethodsProvider()
-    {
-        return array(
-            array('tests/Resources/ModelBasedCheckout/deleteStoredPaymentMethods-success.json', 200),
-        );
+        $this->assertTrue(true, 'no exception');
     }
 
     public function testPaymentMethodSerialization()