chore: Fix usage of validateHMAC #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing a fix to this issue! We're merging this to implement your changes. Kind Regards, |
DjoykeAbyah
approved these changes
Jul 29, 2024
jillingk
approved these changes
Jul 29, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
We are currently working on an Adyen integration and struggled with the validateHMAC method. It looks like there were some problems:
The hmacSign sent in the webhook request is never in hexadecimal, so ctype_xdigit is always false. We must validate the HMAC key $hmacKey and use it in the pack function.
Finally, we need to compare the expectedSign with the hmacSign passed in the parameters.
Is this correct for you?
Thank you,
Tested scenarios
Fixed issue: