Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geofence example added #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

udhaykumarbala
Copy link
Contributor

No description provided.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • run cargo fmt & cargo clippy (we don't have a CI for these checks yet but you should run them on the code locally.)

As an additional note, I saw that there is a FenceType which can be used on a Polygon, but the Polygon itself uses i32 inside. We should improve this API in the future.


let upload_geofence_request = mav_sdk::grpc::geofence::UploadGeofenceRequest { polygons: vec![
mav_sdk::grpc::geofence::Polygon {
points:vec![mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },], fence_type: 0, },
Copy link
Member

@elpiel elpiel Aug 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's a great start. could we just add actual coordinates here?

  • Let's use the actual GPS coordinates of the drone (at the moment) and update the Polygon accordingly.
    E.g. current coordinates +/- a value in degrees in all directions to get a rectangle with a given size. Keep in mind that we work with degrees here so that we can define the distance in degrees, instead of size (i.e. ~0.125 degrees instead of ~14 km). We do need to choose a valid value as "Each degree of latitude is approximately 111 kilometres apart" (https://www.thoughtco.com/degree-of-latitude-and-longitude-distance-4070616).

  • Import Point, UploadGeofenceRequest, ClearGeofenceRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants