Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gyro offsets to metadata struct #281

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Add gyro offsets to metadata struct #281

merged 5 commits into from
Oct 26, 2023

Conversation

irisnwang
Copy link
Contributor

@irisnwang irisnwang commented Oct 12, 2023 •
edited
Loading

Closes #101

  • adds offsets
  • documents units in imu sensor data

@irisnwang irisnwang requested a review from a team as a code owner October 12, 2023 01:04
@irisnwang irisnwang marked this pull request as draft October 12, 2023 01:13
@mcm001
Copy link
Contributor

mcm001 commented Oct 12, 2023

This'll need updates to our offload code anyways, I would update that so you can test you can offload the offsets and things

@irisnwang irisnwang marked this pull request as ready for review October 12, 2023 02:25
mcm001
mcm001 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise I mean seems great! We should test offloading and then we can send it

common/system/filtering/filters.h Show resolved Hide resolved
@irisnwang
Copy link
Contributor Author

Otherwise I mean seems great! We should test offloading and then we can send it

Offloading is tested and functional :))

@irisnwang irisnwang merged commit 112c4aa into main Oct 26, 2023
29 checks passed
@irisnwang irisnwang deleted the gyro-offset-metadata branch October 26, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 left review comments

@SamHaggans SamHaggans SamHaggans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gyro offset values should be stored in flight metadata
3 participants
@irisnwang @mcm001 @SamHaggans