The 'X' is not appearing in the modal (#74)

* Fix classic modal issue
Affirm · May 20, 2020 · 6802788 · 6802788
1 parent 2361a04
commit 6802788
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/AffirmSDK/AffirmPromoModalViewController.m b/AffirmSDK/AffirmPromoModalViewController.m
@@ -53,7 +53,7 @@ - (WKWebView *)webView:(WKWebView *)webView createWebViewWithConfiguration:(WKWe
 {
     NSURL *url = navigationAction.request.URL;
     if (navigationAction.targetFrame == nil && [url.absoluteString rangeOfString:@"affirm.com/apps/prequal"].location != NSNotFound) {
-        NSString *fullURL = [url.absoluteString stringByAppendingString:@"&isSDK=true"];
+        NSString *fullURL = [url.absoluteString stringByAppendingString:[NSString stringWithFormat:@"&referring_url=%@", AFFIRM_PREQUAL_REFERRING_URL]];
         [webView loadRequest:[[NSURLRequest alloc] initWithURL:[NSURL URLWithString:fullURL]]];
     }
     return nil;
@@ -64,7 +64,7 @@ - (WKWebView *)webView:(WKWebView *)webView createWebViewWithConfiguration:(WKWe
 - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy))decisionHandler
 {
     NSString *urlString = navigationAction.request.URL.absoluteString;
-    if ([urlString isEqualToString:AFFIRM_CHECKOUT_CANCELLATION_URL]) {
+    if ([urlString isEqualToString:AFFIRM_PREQUAL_REFERRING_URL]) {
         [self dismiss];
         decisionHandler(WKNavigationActionPolicyCancel);
         return;

diff --git a/AffirmSDK/AffirmPromotionalButton.m b/AffirmSDK/AffirmPromotionalButton.m
@@ -179,6 +179,7 @@ - (void)awakeFromNib
 
 - (void)setup
 {
+    self.showPrequal = YES;
     self.clickable = NO;
     [self configureWebView];
     [self configureButton];
@@ -379,7 +380,6 @@ - (void)configureWithHtmlString:(NSString *)htmlString
 {
     [AffirmValidationUtils checkNotNil:amount name:@"amount"];
     self.amount = amount.toIntegerCents;
-    self.showPrequal = YES;
 
     BOOL hasRemoteCss = remoteCssURL != nil;
     NSString *jsURL = [AffirmConfiguration sharedInstance].jsURL;

diff --git a/Examples/Examples/ViewController.m b/Examples/Examples/ViewController.m
@@ -174,11 +174,11 @@ - (void)configurPromotionalMessage
     NSURL *cssURL = [[NSBundle mainBundle] URLForResource:@"css_promo_sample" withExtension:@"css"];
 
     // Configure promotionalButton with html styling automatically
-//    [self.promotionalButton configureByHtmlStylingWithAmount:dollarPrice
-//                                              affirmLogoType:AffirmLogoTypeName
-//                                                 affirmColor:AffirmColorTypeBlueBlack
-//                                               remoteFontURL:fontURL
-//                                                remoteCssURL:cssURL];
+    [self.promotionalButton configureByHtmlStylingWithAmount:dollarPrice
+                                              affirmLogoType:AffirmLogoTypeName
+                                                 affirmColor:AffirmColorTypeBlueBlack
+                                               remoteFontURL:fontURL
+                                                remoteCssURL:cssURL];
 
     [AffirmDataHandler getPromoMessageWithPromoID:nil
                                            amount:dollarPrice

diff --git a/README.md b/README.md
@@ -211,4 +211,4 @@ All notable changes to this project will be documented in [changelog document](h
 Package Size
 ==============
 
-Final Binary Size: 0.6 MB
+Final Binary Size: 0.67 MB