Исправлен код DAO и сущностей #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Afftobus
approved these changes
Jan 16, 2023
| * избежать org.hibernate.LazyInitializationException | ||
| * Также в запрос должен передаваться параметр employerId | ||
| * <p> | ||
| * https://vladmihalcea.com/the-best-way-to-handle-the-lazyinitializationexception/ | ||
| */ | ||
| public Employer getEager(int employerId) { | ||
| return getSession() | ||
| .createQuery("from Employer employer", Employer.class) | ||
| .getSingleResult(); | ||
| .createQuery("from Employer employer join fetch employer.vacancies WHERE employer.id = :employerId", Employer.class) |
There was a problem hiding this comment.
лучше LEFT join fetch, иначе не будут выбираться работодатели без вакансий
| @@ -1,9 +1,15 @@ | |||
| package ru.hh.school.entity; | |||
|
|
|||
| import javax.persistence.*; | |||
There was a problem hiding this comment.
мы не используем звёздочки, всё что нужно импортим явно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Необходимо поправить код DAO и сущностей