Try next DFS referral if fail to find link referral #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While getReferralTransport() deals with the use case of a failed connection to the referred server, it does not address a successful connection that subsequently fails while calling getReferral. There are probably a number of ways this could occur, but in our case one set of servers where failing with SmbUnsupportedOperationExceptions during getReferral, due to misconfig. In the prior logic, this would cause an immediate failure to find the link, rather than trying the other referrals received from the getRootReferral. The new logic follows the pattern used in getReferralTransport to loop until we either succeed and break out or follow the referrals all the way back to the first option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
getReferralTransport()deals with the use case of a failed connection to the referred server, it does not address a successful connection that subsequently fails while callinggetReferral().There are probably a number of ways this could occur, but in our case one set of servers where failing with
SmbUnsupportedOperationExceptions duringgetReferral(), due to misconfig on the namespace server. In the prior logic, this would cause an immediate failure to find the link, rather than trying the other referrals received from thegetRootReferral().The new logic follows the pattern used in
getReferralTransport()to loop until we either succeed and break out or follow the referrals all the way back to the first option.