Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update cf pages user agent name #1237

Merged
merged 1 commit into from
Oct 12, 2024
Merged

ci: update cf pages user agent name #1237

merged 1 commit into from
Oct 12, 2024

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Oct 9, 2024

Description

When working on sites deployed via CF Pages, devs have been having issues trying to debug build failures. We have a custom action that fetches build logs from CF and displays them in a github workflow by posting a comment with an easy to access logs link.

The root cause was a change in user agent name (presumably from CF's side). Have verified this is a user agent mismatch by forking this repo to my personal account, and adding relevant debug info. [github triggers issue_comment triggered workflows from the default branch hence the workaround for debugging]

Can verify name mismatch here

Debugging information:
Is Pull Request: true
Comment Author: cloudflare-workers-and-pages[bot]
Condition Met: false

@Agoric Agoric deleted a comment from cloudflare-workers-and-pages bot Oct 9, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 654b102
Status: ✅  Deploy successful!
Preview URL: https://a1d07e92.documentation-7tp.pages.dev
Branch Preview URL: https://logs-fetcher-debug.documentation-7tp.pages.dev

View logs

@mujahidkay mujahidkay added devex and removed devex labels Oct 9, 2024
@toliaqat
Copy link
Contributor

Changes in cf-logs-fetcher.yml only get triggered after it has been merged because it is triggered on the comment of the PR and not the original PR itself.

@mujahidkay
Copy link
Member Author

mujahidkay commented Oct 12, 2024

Changes in cf-logs-fetcher.yml only get triggered after it has been merged because it is triggered on the comment of the PR and not the original PR itself.

yep, i'm aware. issue_comment based triggers use the workflow from default branch.

I created a fork of this repo that I will set up using a personal CF account and debug that way by pushing directly to master/main.

@mujahidkay mujahidkay changed the title debugging logs fetcher ci: update cf pages user agent name Oct 12, 2024
@mujahidkay mujahidkay removed the devex label Oct 12, 2024
@mujahidkay mujahidkay self-assigned this Oct 12, 2024
@mujahidkay mujahidkay marked this pull request as ready for review October 12, 2024 11:50
Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good as per the verification you did.
But I'm curious if we can have any CF thread where they changed their botname. Did we find something online or may be in their release notes/log?

@mujahidkay
Copy link
Member Author

Change looks good as per the verification you did. But I'm curious if we can have any CF thread where they changed their botname. Did we find something online or may be in their release notes/log?

None that I could find. This is the only relevant changelog (remotely) that is relevant. I would assume it made changes to the overarching, unified GitHub app as well.

@mujahidkay mujahidkay merged commit 3b40b16 into main Oct 12, 2024
6 checks passed
@mujahidkay mujahidkay deleted the logs-fetcher-debug branch October 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants