Fix 'connected' command for Minecraft/Bukkit 1.6.2. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on separate line.
Ahtenus
added a commit
that referenced
this pull request
Aug 22, 2013
Fix 'connected' command for Minecraft/Bukkit 1.6.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #123, the 'connected' command is broken as of Minecraft (Bukkit) 1.6.2. This commit solves the problem in the following way:
Input log in reverse direction to grep, search for first appearance of "players online", forward this line and the line before. The line before is contains a
", "-separated list of connected players. Ouput each player name on its own line and properly deal with color ASCII codes.Also, a delay of three seconds before evaluating the log file seems to be over the top. The server should immediately return the answer and write to the log file, so I believe that one second of delay is safe enough.