Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization option added #2

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Localization option added #2

wants to merge 9 commits into from

Conversation

JBraunsmaJr
Copy link
Collaborator

Added localization to our template.

This requires an update from the DCS library before getting merged

@JBraunsmaJr JBraunsmaJr added the enhancement New feature or request label Dec 23, 2021
@JBraunsmaJr JBraunsmaJr self-assigned this Dec 23, 2021
Lulalaby
Lulalaby requested changes Dec 24, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments shouldn't be here XD

src/Content/DisCatSharpProjectBot/translations/my_simple_command.json Outdated Show resolved Hide resolved
src/Content/DisCatSharpProjectBot/translations/my_simple_command.json Outdated Show resolved Hide resolved
src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translations/my_simple_command.json Outdated Show resolved Hide resolved
src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translations/my_simple_command.json Outdated Show resolved Hide resolved
@Lulalaby Lulalaby added the on-hold This won't be merged for now label Dec 24, 2021
@JBraunsmaJr
Copy link
Collaborator Author

Yeaaaaaaa.... I just copied from docs lol

@Lulalaby Lulalaby self-requested a review December 27, 2021 02:01
@JBraunsmaJr
Copy link
Collaborator Author

Not sure how I feel about a project template targeting nightly builds. Is it possible that we move to a concept such as "preview" or "release candidate" work flows?

Could be safer as it involves "updating" on consumer end and less "breaking" changes that could be implemented overnight.

@Lulalaby
Copy link
Member

Lulalaby commented Sep 5, 2022

Not sure how I feel about a project template targeting nightly builds. Is it possible that we move to a concept such as "preview" or "release candidate" work flows?

Could be safer as it involves "updating" on consumer end and less "breaking" changes that could be implemented overnight.

For now the latest nightly is the most stable we have, it's actually a release candidate.
I would prefer using that at least for now

@Lulalaby Lulalaby removed the on-hold This won't be merged for now label Sep 16, 2022
@Lulalaby
Copy link
Member

Ready to go

@Lulalaby Lulalaby marked this pull request as ready for review September 16, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Requested changes must be addressed to merge this pull request.

Assignees

@JBraunsmaJr JBraunsmaJr

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBraunsmaJr @Lulalaby