Update COMET to work with OptiMathSat 1.7.3, Avoid using deprecated pandas functions. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgomber
added a commit
to sgomber/COMET
that referenced
this pull request
Nov 12, 2022
- Enabled COMET to work with OptiMathSat 1.7.3, which uses the MathSat 5 syntax. MathSat 5 syntax requires that the -optimization=true flag be passed in order to utilize optimization extensions. - Changed use of pd.append, which is deprecated, to pd.concat. - Removed the silent catching of exceptions, since it prevented me from detecting any errors in OptiMathSat. - Stopped deleting the temporary files that are created, since they automatically delete themselves. (Changes picked from AishwaryaSivaraman#3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves enables COMET to work with OptiMathSat 1.7.3, which uses the MathSat 5 syntax.
MathSat 5 syntax requires that the
-optimization=trueflag be passed in order to utilize optimization extensions.Furthermore, I also changed use of pd.append, which is deprecated, to pd.concat.
I also removed the silent catching of exceptions, since it prevented me from detecting any errors in OptiMathSat.
Finally, I stopped deleting the temporary files that are created, since they automatically delete themselves.