Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMET to work with OptiMathSat 1.7.3, Avoid using deprecated pandas functions. #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pimpale
Copy link

@pimpale pimpale commented May 19, 2022

This PR solves enables COMET to work with OptiMathSat 1.7.3, which uses the MathSat 5 syntax.
MathSat 5 syntax requires that the -optimization=true flag be passed in order to utilize optimization extensions.

Furthermore, I also changed use of pd.append, which is deprecated, to pd.concat.

I also removed the silent catching of exceptions, since it prevented me from detecting any errors in OptiMathSat.

Finally, I stopped deleting the temporary files that are created, since they automatically delete themselves.

sgomber added a commit to sgomber/COMET that referenced this pull request Nov 12, 2022
- Enabled COMET to work with OptiMathSat 1.7.3, which uses the MathSat 5 syntax.
MathSat 5 syntax requires that the -optimization=true flag be passed in order to utilize optimization extensions.

- Changed use of pd.append, which is deprecated, to pd.concat.

- Removed the silent catching of exceptions, since it prevented me from detecting any errors in OptiMathSat.

- Stopped deleting the temporary files that are created, since they automatically delete themselves.

(Changes picked from AishwaryaSivaraman#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant