-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped the exporter to support OpenSearch v2.1 #76
Conversation
Signed-off-by: Victor Nilsson <[email protected]>
@vinylen could you please rebase against latest |
e061cb8
to
ffe27bf
Compare
@reta Does it look OK now? |
this isn't working yet, see the failed build:
so a gradle major release upgrade is in order first 😢 |
@vinylen apologies, mind doing another rebase? thank you :) |
Signed-off-by: Victor Nilsson <[email protected]>
Should be good to go now @reta |
LGTM. I can squash all three commits and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
IMO we should have only a single commit but we can squash them from GitHub UI when merging.
Are you planning to make a release for this one? |
Signed-off-by: Victor Nilsson [email protected]