Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped the exporter to support OpenSearch v2.1 #76

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

vinylen
Copy link
Contributor

@vinylen vinylen commented Jul 8, 2022

Signed-off-by: Victor Nilsson [email protected]

Signed-off-by: Victor Nilsson <[email protected]>
@vinylen vinylen requested a review from lukas-vlcek as a code owner July 8, 2022 06:41
@reta
Copy link
Contributor

reta commented Jul 11, 2022

@vinylen could you please rebase against latest main? thank you.

@Maglore Maglore mentioned this pull request Jul 12, 2022
5 tasks
@vinylen vinylen force-pushed the 2.1.0-updatev2 branch 3 times, most recently from e061cb8 to ffe27bf Compare July 12, 2022 08:25
@vinylen
Copy link
Contributor Author

vinylen commented Jul 12, 2022

@reta Does it look OK now?

@reta
Copy link
Contributor

reta commented Jul 12, 2022

@reta Does it look OK now?

@vinylen certainly, we'll do 2.0.1.0 release and move on with this one right away, thanks a lot!

@rursprung
Copy link
Contributor

this isn't working yet, see the failed build:

[..]
Welcome to Gradle 6.8.3!
[..]
* What went wrong:
A problem occurred evaluating root project 'prometheus-exporter'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
   > Gradle 7.4.1+ is required
[..]

so a gradle major release upgrade is in order first 😢

@rursprung
Copy link
Contributor

so a gradle major release upgrade is in order first 😢

i took a quick stab at this and it turned out to be relatively easy: see #77
i briefly tested it and can confirm that with #77 it then also works to bump the version to 2.1.0.0 and accordingly build against OpenSearch 2.1.0.

@reta
Copy link
Contributor

reta commented Jul 12, 2022

@vinylen apologies, mind doing another rebase? thank you :)

Signed-off-by: Victor Nilsson <[email protected]>
@vinylen
Copy link
Contributor Author

vinylen commented Jul 12, 2022

Should be good to go now @reta

@lukas-vlcek
Copy link
Collaborator

LGTM. I can squash all three commits and merge.

Copy link
Collaborator

@lukas-vlcek lukas-vlcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
IMO we should have only a single commit but we can squash them from GitHub UI when merging.

@reta reta merged commit 37d79c3 into Aiven-Open:main Jul 12, 2022
@amalgamm
Copy link

Are you planning to make a release for this one?

@lukas-vlcek
Copy link
Collaborator

lukas-vlcek commented Jul 13, 2022

@amalgamm Yes, it will be out today. done: #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants