compressor: replace snappy with cramjam #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aris-aiven
force-pushed
the
aris-cramjam-snappy
branch
6 times, most recently
from
d39e85d
to
7bcbaf7
Compare
This allows using structural pattern matching
aris-aiven
force-pushed
the
aris-cramjam-snappy
branch
2 times, most recently
from
eb942f8
to
e6b789e
Compare
The python-snappy library is no longer maintained. Cramjam is almost a drop-in replacement that allows for a considerable speedup both in the compression and decompression tasks. The relevant benchmark for snappy's framed format [1]. Add more tests for compression and decompression & modernize some pattern matching. [1]: https://github.com/milesgranger/pyrus-cramjam/blob/33c0516374fb9726ddcb82c5dfbe86be96d2cd35/cramjam-python/benchmarks/README.md
aris-aiven
force-pushed
the
aris-cramjam-snappy
branch
from
e6b789e
to
eaf676d
Compare
|
Not going to pursue this right now, we have higher priority work on our roadmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Replaces the python-snappy dependency with cramjam.
Why this way
The python-snappy library is no longer maintained (see 1). Cramjam is a drop-in replacement that allows for a considerable speedup both in the compression and decompression tasks. The relevant benchmark for snappy's framed format 2.
Before we accept this PR, we should benchmark cramjam ourselves with realistic workloads.