Improve handling of AIFF-C compression type #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pacmog v0.4.2, the following AIFF-C compression types were supported:
pacmog/src/aiff.rs
Lines 72 to 77 in 80de8c2
These types are compatible with most commonly used AIFF files. However, they are insufficient for certain edge cases:
Related issues:
Additionally, there are rare cases where the bit-depth specified in the COMMON chunk does not match the bit-depth assumed by the compression type:
This PR improves the handling of AIFF-C compression types. If the compression type is present and not 'NONE', the bit-depth specified in the COMMON chunk is overwritten with the value corresponding to the compression type.