feat: add debounce props #337
Open
+183
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlito40
force-pushed
the
feat/debounce
branch
from
366f4bb
to
68fddd1
Compare
sthales
approved these changes
Jan 29, 2020
|
When the conflict will be resolved? I believe that will solve performance issues in mobiles. Scroll-event triggered multiple times when scrolling with touch event and that causes some glitches! |
|
All the conflicts has been resolved 👍 |
|
It should be a throttle instead of a debounce to avoid blank content for too long while scrolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
This merge request adds a basic debounce on scroll if needed.
Right now i'm experiencing some little perf issues on desktop (and only on desktop) when i scroll too fast to the bottom of my dynamic scroller. Everything become clunky and nearly unusable.
To be fair everything works fine if i use IdState but my use case prevents me from using it without a huge refactor. So i must put a
keyon my child components inside my DynamicScrollerItem which is a huge performance killer on desktop (not so much on mobile ironically).As a workaround, i've add a
debounceprops that will debounce thehandleScrollmethods if it's not falsy. It's not optimal but it's now usable and does the job for my use case.Feel free to merge or not.
i renamed refreshTimout to refreshTimeout