-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix newDate() and option for reverted back Now() date format #1534
Conversation
c72d2df
to
15fefcf
Compare
Please correct file formatting using |
50aadda
to
70c5061
Compare
@alsundukov Looks really good. I have a few questions. Please check the comments in the code. |
newDate() for Safari (et. al.) Supported formats: "2022.01.10 04:10", "2022.01.10 04:10:11", "2022.01.10 04:10:11.123", "2022-01-10 04:10", "2022-01-10 04:10:11", "2022-01-10 04:10:11.123", "2022.1.10", "2022-1-1" ... Fix for NOW() in Firefox: reverted back the date format: 2022-11-01 -> 2022.11.01
70c5061
to
82f66ed
Compare
@mathiasrw I have shortened the comment. |
I really like the work you did here. Sorry that it took me so long to submerge myself into the details. I felt we had to get timezones included into this. On the way I also got around to understand the details in https://stackoverflow.com/questions/2587345/why-does-date-parse-give-incorrect-results/20463521#20463521 and its clear that we should rely mainly on our own parsing to combat inconsistencies. I see there is an error now in the cicd that I did not get locally. Looking into this tomorrow and hope its not a "timezone of the computer where we are testing" thing. On a side note: I now see why #1627 is happening and will include that in the next release so we can bundle two breaking changes. |
This reverts commit 6a4241a.
* Better date support for Safari * Config separators for now() output * Support timezone timestamps
This commit was moved to the v5 branch so we can prepare a few breaking changes in one go and release together. |
newDate() for Safari (et. al.)
Supported formats:
"2022.01.10 04:10",
"2022.01.10 04:10:11",
"2022.01.10 04:10:11.123",
"2022-01-10 04:10",
"2022-01-10 04:10:11",
"2022-01-10 04:10:11.123",
"2022.1.10",
"2022-1-1"
...
Fix for NOW() in Firefox: option for reverted back the date format: 2022-11-01 -> 2022.11.01