-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GETDATE, NOW as alias to parser + allow CURRENT_TIMESTAMP with parenthesis #1980
Add GETDATE, NOW as alias to parser + allow CURRENT_TIMESTAMP with parenthesis #1980
Conversation
@mathiasrw whenever you have time, could you please check out this PR? Thanks. |
Hi Paul. I really like what you did here. Thank you so much. This is probably how we should have done it from the beginning. The changes in test/test845.js indicate that this is a breaking change so I will bundle this into a bucket of changes waiting for us to bump major version. Probably during the next few months as we are in the work of restructuring the whole source into ES6 friendly components. |
@mathiasrw Thanks, good to know that will take a while for this to get into a release. Do you agree? If so, i could work on a PR (WiP: https://github.com/AlaSQL/alasql/compare/develop...blueconic:alasql:feature/add-all-date-functions-to-parser?expand=1) |
@paulrutter We are talking about all fields named DATE/NOW/GETDATE/YEAR/MONTH having to be wrapped in escape chars, right? |
@mathiasrw yes, indeed. In backticks/quotes. |
@mathiasrw See #1982 for additional work on the parser. |
Closed in favor of #1982 |
Sooooo, this one is to be closed? |
@mathiasrw this was more the issue related to the original PR (#1980), which i closed. |
Add the following functions to the parser:
Also add
CURRENT_TIMESTAMP()
to the parser (with parenthesis).now
is a reserved keyword. It was already, it was just not validated.See #1979
Thank you for the time you are putting into AlaSQL!