Refactoring

[PointlessUser]

No description provided.

[PointlessUser]

Black Formatter caused a lot of the line changes. The other 4 commits are the ones that need review

[rcunrau]

If there's something other than auto refactoring you want looked at you should put it into a separate PR.

[PointlessUser]

I reverted the auto-refactoring

[rcunrau]

I see the reversion commits, and yet there are still 26 files changed, and all the commit titles still include "refactor". Did you do all that refactoring by hand? (Impressive :-) Did you test your changes in any way? Normally, a refactor doesn't need (as much) testing because the changes aren't intended to be semantic, but for an interpreted language you can't use "see, it compiles" as proof you didn't break anything.

[PointlessUser]

I'm not sure how to test it. The instructions on the readme don't seem to work

[rcunrau]

There are a bunch of different configurations, depending on whether you are connecting to a dev board or flat sat via UHF or USB. We can meet next week to try it out (although it's a busy week with MCR etc).

[rcunrau]

It says you merged 'master' into 'Refactoring', which, unfortunately, is backwards :-/
We actually want to merge 'Refactoring' into 'master' (as per the Merge buttons below) once we have tested that we haven't regressed anything. Did you do 'git pull' into your branch? You might be able to undo it with 'git unpull', but that doesn't usually work. The command you want if your branch is out of date is "git pull --rebase' to place your changes on top of the lastest master.

[PointlessUser]

If you're busy this week, we could test it next week.

Also I merged main into refactoring so that the code is up to date with the main branch. There was a merge conflict I wanted to resolve and it makes merging back into main a lot easier

[rcunrau]

It's true you can't merge your branch if there are conflicts. Unfortunately, merging main into the branch messes up the history. Fortunately, we are unlikely to have to use the history to find any regressions. We're trying to follow the same processes you're going to have to follow when you get to industry. I can help you resolve the conflicts if it happens again.