Devin/feature/create deployables interface fprime component #20
Conversation
…ent used with the simulated satellite system.
…Deployment topology
…ort handling. A new thread is now created upon client socket creation that constantly checks the port for readable data, and upon receving it sends it to the DeployablesService component via async input port.
…tempt deploying all deployables. Not yet tested.
…lesService and DeployablesInterface components, talking to simulated Deployables python program.
…ity warning level from low to high for LEOP deployment sequence start and end logs.
| closeSocket(); | ||
| } | ||
|
|
||
| int DeployablesInterface :: openSocket(){ |
There was a problem hiding this comment.
If all the Components are connecting with TCP you might want to make this a common utility
There was a problem hiding this comment.
I am working on this now, although I am not sure how to modify the Fprime build / compile process to compile a seperate 'TCP_stuff' source file and link it , given it will not be an 'fprime' component.
| timeout.tv_sec = 10; | ||
| timeout.tv_usec = 0; | ||
|
|
||
| int activity = select(client_fd + 1, &set, NULL, NULL, &timeout); |
There was a problem hiding this comment.
Do you expect more than one channel from the device(s)? Just surprised you're using select() here
There was a problem hiding this comment.
I may be mistaken with handling sockets, but I read that unix system calls are regularly blocking. Given the communication between subsystem and OBC is asynchronous I wanted to be sure the client socket on the OBC stays open non-blocking for reads.
| } | ||
| } | ||
| } | ||
|
|
||
| void DeployablesInterface :: closeSocket(){ | ||
| close(client_fd); | ||
| fprintf(stderr, "Socket closed \n"); | ||
| // fprintf(stderr, "Socket closed \n"); |
There was a problem hiding this comment.
Hopefully all the commented out printfs are only there until you verify that logging is working?
No description provided.