fix component casting test #180
rrasmuss4200Annotations
25 warnings
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs#L89
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs:89:57
|
89 | handle_user_input(stdin_buf.as_slice(), &mut ipc_server.as_mut().unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ipc_server.as_mut().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs#L37
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs:37:23
|
37 | ipc_write(&ipc_server.data_fd.as_ref().unwrap(), serialized_msg.as_slice())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ipc_server.data_fd.as_ref().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs#L30
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/dev_tools/ipc_server_dev_tool/src/main.rs:30:23
|
30 | ipc_write(&ipc_server.data_fd.as_ref().unwrap(), serialized_msg.as_slice())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ipc_server.data_fd.as_ref().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L301
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:301:43
|
301 | write_msg_to_uhf_for_downlink(&mut tcp_interface.as_mut().unwrap(), ack_msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tcp_interface.as_mut().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L282
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:282:52
|
282 | ... let _ = ipc_write(&fd, &decrypted_byte_vec);
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `decrypted_byte_vec`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L282
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:282:47
|
282 | ... let _ = ipc_write(&fd, &decrypted_byte_vec);
| ^^^ help: change this to: `fd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L221
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:221:67
|
221 | ... let _ = write_msg_to_uhf_for_downlink(&mut tcp_interface.as_mut().unwrap(), deserialized_msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tcp_interface.as_mut().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this let-binding has unit value:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L221
warning: this let-binding has unit value
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:221:29
|
221 | ... let _ = write_msg_to_uhf_for_downlink(&mut tcp_interface.as_mut().unwrap(), deserialized_msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `write_msg_to_uhf_for_downlink(&mut tcp_interface.as_mut().unwrap(), deserialized_msg);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L213
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:213:71
|
213 | ... write_msg_to_uhf_for_downlink(&mut tcp_interface.as_mut().unwrap(), cur_msg);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tcp_interface.as_mut().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L201
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:201:71
|
201 | ... send_initial_bulk_to_gs(deserialized_msg, &mut tcp_interface.as_mut().unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tcp_interface.as_mut().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this let-binding has unit value:
ex3_obc_fsw/handlers/coms_handler/src/main.rs#L177
warning: this let-binding has unit value
--> ex3_obc_fsw/handlers/coms_handler/src/main.rs:177:9
|
177 | let _coms_bytes_read_res = poll_ipc_server_sockets(&mut servers);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `poll_ipc_server_sockets(&mut servers);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
unnecessary `if let` since only the `Some` variant of the iterator element is used:
ex3_obc_fsw/bulk_msg_dispatcher/src/main.rs#L52
warning: unnecessary `if let` since only the `Some` variant of the iterator element is used
--> ex3_obc_fsw/bulk_msg_dispatcher/src/main.rs:52:9
|
52 | for server_opt in servers {
| ^ ------- help: try: `servers.into_iter().flatten()`
| _________|
| |
53 | | if let Some(server) = server_opt {
54 | | if let Some(msg) = handle_client(server)? {
55 | | if server.socket_path.contains("gs_bulk") {
... |
108 | |
109 | | }
| |_________^
|
help: ...and remove the `if let` statement in the for loop
--> ex3_obc_fsw/bulk_msg_dispatcher/src/main.rs:53:13
|
53 | / if let Some(server) = server_opt {
54 | | if let Some(msg) = handle_client(server)? {
55 | | if server.socket_path.contains("gs_bulk") {
56 | | if msg.header.msg_type == MsgType::Ack as u8 {
... |
106 | | }
107 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
|
|
redundant pattern matching, consider using `is_none()`:
ex3_shared_libs/interfaces/ipc/src/lib.rs#L235
warning: redundant pattern matching, consider using `is_none()`
--> ex3_shared_libs/interfaces/ipc/src/lib.rs:235:16
|
235 | if let None = server {
| -------^^^^--------- help: try: `if server.is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
ex3_shared_libs/interfaces/ipc/src/lib.rs#L229
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> ex3_shared_libs/interfaces/ipc/src/lib.rs:229:41
|
229 | pub fn poll_ipc_server_sockets(servers: &mut Vec<&mut Option<IpcServer>>) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [&mut Option<IpcServer>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
redundant pattern matching, consider using `is_none()`:
ex3_shared_libs/interfaces/ipc/src/lib.rs#L96
warning: redundant pattern matching, consider using `is_none()`
--> ex3_shared_libs/interfaces/ipc/src/lib.rs:96:16
|
96 | if let None = client {
| -------^^^^--------- help: try: `if client.is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
empty doc comment:
ex3_shared_libs/interfaces/ipc/src/lib.rs#L90
warning: empty doc comment
--> ex3_shared_libs/interfaces/ipc/src/lib.rs:90:1
|
90 | ///
| ^^^
|
= help: consider removing or filling it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
= note: `#[warn(clippy::empty_docs)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
|
|
build
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
|
|
build
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
|