Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip devnet script client generation when total_clients=0 #3368

Open
wants to merge 2 commits into
base: mainnet-staging
Choose a base branch
from
Open

Skip devnet script client generation when total_clients=0 #3368

wants to merge 2 commits into from

Conversation

vicsn
Copy link
Contributor

@vicsn vicsn commented Jul 25, 2024

Motivation

When starting a devnet with num_clients=0, the current script would still launch a client.

Test Plan

Ran it locally.

@vicsn vicsn requested a review from niklaslong July 25, 2024 11:09
niklaslong
niklaslong approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@niklaslong niklaslong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and tested it locally as well) 👍

raychu86
raychu86 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklaslong niklaslong niklaslong approved these changes

@raychu86 raychu86 raychu86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicsn @niklaslong @raychu86