feat: add private-key-file flag to snarkos developer execute command #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Sep 25, 2024
vicsn
approved these changes
Sep 26, 2024
|
There is a CI job failing. @zkxuerb if you can help on how to proceed on this one. |
|
The |
|
#3429 supersedes this to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The execute command is often used in secure contexts, and providing an option for a file input reduces potential cleartext private key exposure in both troubleshooting and production environments.
Test Plan
An additional test case has been added for parsing the --private-key-file flag
Related PRs
n/a