-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Use heuristics to avoid allocations in Sanitizer::str_till_eol #2517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
changed the title
[perf] Use heuristics to avoid allocations in Sanitizer::str_till_eol
[Perf] Use heuristics to avoid allocations in Sanitizer::str_till_eol
Jul 10, 2024
@ljedrz Could you fix the |
The |
zosorock
requested review from
evanmarshall,
fulltimemike,
zkxuerb,
zklimaleo and
a team
October 22, 2024 00:19
Superseded by #2563 to merge in |
gluax
approved these changes
Oct 31, 2024
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
ljedrz
force-pushed
the
perf/parsing_sanitizer2
branch
from
November 5, 2024 10:57
831cdf6
to
42d999b
Compare
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Superseded by #2563. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(transferred from ProvableHQ#6, and asking @d0cd for a review as suggested there)
The
Sanitizer
is used very prominently in our parsing functions, and it is also a source of many allocations, most of which are temporary and avoidable.The potential perf improvements are quite large, and I've measured them both with a 15-minute run of a
--dev
node and usinghyperfine
on a small binary that parsed all the valid.aleo
programs currently present in the snarkVM codebase.dev node:
Program::from_str
specifically, allocs are reduced by ~64%, of which temp allocs ~88%parsing all
.aleo
programs usingProgram::from_str
: