New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make `variable_limit` tight #2545

Open

zhiqiangxu wants to merge 1 commit into AleoNet:staging from zhiqiangxu:fix_new_variable

Contributor

zhiqiangxu commented Sep 5, 2024

if Self::num_variables() == limit, should not allow new variables.


          make variable_limit tight

dccd879

Contributor

vicsn commented Sep 5, 2024

Appreciate the contribution, but I recommend to close the PR because:

Semantically, limit can be interpreted as exclusive
The previous setup was extensively tested so should not be adjusted without significant motivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet